Re: [PATCH] Make the tab width used for whitespace checks configurable

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 30, 2010, 01:31 UTC
Message-ID: <7vhbezwqan.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4CF366B1.8070400@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

Show 16 quoted lines

> From: Johannes Sixt <j6t@kdbg.org>
>
> A new whitespace "rule" is added that sets the tab width to use for
> whitespace checks and fix-ups and replaces the hard-coded constant 8.
>
> Since the setting is part of the rules, it can be set per file using
> .gitattributes.
>
> The new configuration is backwards compatible because older git versions
> simply ignore unknown whitespace rules.
>
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
>  I have a project that uses tab width 4, and which has a lot of whitespace
>  errors. This is very helpful to spot them when lines are changed that
>  are indented with 4 spaces.

Heh, I like it. This will be the second killer feature to upgrade to the upcoming release. We really should start calming things down.

I am sort of surprised how the patch does not have to touch neither diff.c nor apply.c at all---it demonstrates how solidly and cleanly the ws.c infrastructure was done in the first place, I guess ;-).

Thanks.