git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2 maint] apply --whitespace=fix: fix tab-in-indent

From
Chris Webb <chris@arachsys.com>
Date
Nov 30, 2010, 23:19 UTC
Message-ID
<20101130231909.GA2425@arachsys.com>
In-Reply-To
<4CF4B42C.4080104@viscovery.net>
Johannes Sixt <j.sixt@viscovery.net> writes:
Show 6 quoted lines
> When the whitespace rule tab-in-indent is enabled, apply --whitespace=fix
> replaces tabs by the appropriate amount of blanks. The code used
> "dst->len % 8" as the criterion to stop adding blanks. But it forgot that
> dst holds more than just the current line. Consequently, the modulus was
> computed correctly only for the first added line, but not for the second
> and subsequent lines. Fix it.
You're quite right! My mistake, so if you like, please feel free to add
Acked-by: Chris Webb <chris@arachsys.com>
Cheers,
Chris.
Previous: Johannes Sixt
Message 6 of 6 in “Make the tab width used for whitespace checks configurable”
  1. Make the tab width used for whitespace checks configurableJohannes Sixt, Nov 29, 2010
  2. Jonathan NiederNov 29, 2010
  3. Junio C HamanoNov 30, 2010
  4. 1/2 apply --whitespace=fix: fix tab-in-indentJohannes Sixt, Nov 30, 2010
  5. 2/2 Make the tab width used for whitespace checks configurableJohannes Sixt, Nov 30, 2010
  6. Chris WebbNov 30, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.