git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] format-patch: rfc2047-encode newlines in headers

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 23, 2011, 21:47 UTC
Message-ID
<7vhbbu7792.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20110223095917.GC9222@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> These should generally never happen, as we already
> concatenate multiples in subjects into a single line. But
> let's be defensive, since not encoding them means we will
> output malformed headers.

In this particular case, wouldn't it be more conservative and defensive to produce malformed headers so that the patch won't leave the originator? I have a suspicion that mailinfo would choke on the output of this one, even though I didn't try.

Previous: Jeff KingNext: Jeff King
Message 8 of 15 in “generate a valid rfc2047 mail header for multi-line subject.”
  1. generate a valid rfc2047 mail header for multi-line subject.xzer, Feb 14, 2011
  2. Junio C HamanoFeb 22, 2011
  3. Jeff KingFeb 23, 2011
  4. Jeff KingFeb 23, 2011
  5. 1/3 strbuf: add fixed-length version of add_wrapped_textJeff King, Feb 23, 2011
  6. 2/3 format-patch: wrap long header linesJeff King, Feb 23, 2011
  7. 3/3 format-patch: rfc2047-encode newlines in headersJeff King, Feb 23, 2011
  8. Junio C HamanoFeb 23, 2011
  9. Jeff KingFeb 24, 2011
  10. xzerFeb 23, 2011
  11. Jeff KingFeb 23, 2011
  12. Junio C HamanoFeb 23, 2011
  13. Jeff KingFeb 24, 2011
  14. xzerFeb 23, 2011
  15. Junio C HamanoFeb 23, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.