Re: [PATCH] generate a valid rfc2047 mail header for multi-line subject.

From: Jeff King <peff@peff.net>
Date: Feb 23, 2011, 09:48 UTC
Message-ID: <20110223094844.GA9205@sigill.intra.peff.net>
In-Reply-To: <20110223080854.GB2724@sigill.intra.peff.net>

On Wed, Feb 23, 2011 at 03:08:54AM -0500, Jeff King wrote:

Show 12 quoted lines

> Yeah, I think the best path forward is:
> 
>   1. Stop feeding "pre-folded" subject lines to the email formatter.
>      Give it the regular subject line with no newlines.
> 
>   2. rfc2047 encoding should encode a literal newline. Which should
>      generally never happen, but is probably the most sane thing to do
>      if it does.
> 
>   3. rfc2047 should fold all lines at some sane length. As it is now, we
>      may sometimes generate long lines in headers (though in practice, I
>      doubt this is much of a problem).

So here is a series that does this. It still doesn't preserve subject newlines in "format-patch | am", but I don't think that was ever a goal of the code. If we want to add it as an optional feature on top (maybe as part of "-k"?), it should be easy to do (since the rfc2047 encoding will now preserve embedded newlines).

  [1/3]: strbuf: add fixed-length version of add_wrapped_text
  [2/3]: format-patch: wrap long header lines
  [3/3]: format-patch: rfc2047-encode newlines in headers

-Peff