Re: [PATCH 3/7] fetch-pack.c: rename some parameters from "path" to "refname"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 13, 2012, 03:47 UTC
- Message-ID
- <7vhayvids1.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1328941261-29746-4-git-send-email-mhagger@alum.mit.edu>
mhagger@alum.mit.edu writes:
> From: Michael Haggerty <mhagger@alum.mit.edu> > > The parameters denote reference names, which are no longer 1:1 with > filesystem paths.
These three functions are only used as callback from for_each_ref() so they always get the full refname and nothing else (like a partial refname like tags/v1.7.9), so calling them refname makes perfect sense.
Even though I generally try to stay away from this kind of naming churn patches, but hopefully there is nothing in flight to cause horrible conflict with it.
Thanks.