git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/7] Make alternates affect fetch behavior

From
Jeff King <peff@peff.net>
Date
Feb 14, 2012, 22:51 UTC
Message-ID
<20120214225113.GA25558@sigill.intra.peff.net>
In-Reply-To
<1328941261-29746-1-git-send-email-mhagger@alum.mit.edu>
On Sat, Feb 11, 2012 at 07:20:54AM +0100, mhagger@alum.mit.edu wrote:
Show 23 quoted lines
> It used to be that alternate references were not considered "complete"
> when fetching via fetch-pack.  This failure was not so obvious because
> the big benefit of alternates is seen when cloning, and clone used a
> different data path: it put the alternate references into extra refs
> (which makes them look like references within the local repository).
> 
> This patch series teaches fetch-pack to treat objects that are
> available via alternates as "complete".
> 
> Once that is fixed, clone doesn't need to use the special extra_refs
> kludge, so change that.
> 
> And once that is changed, the extra_refs API is no longer needed at
> all, so remove it.
> 
> Michael Haggerty (7):
>   t5700: document a failure of alternates to affect fetch
>   clone.c: move more code into the "if (refs)" conditional
>   fetch-pack.c: rename some parameters from "path" to "refname"
>   fetch-pack.c: inline insert_alternate_refs()
>   everything_local(): mark alternate refs as complete
>   clone: do not add alternate references to extra_refs
>   refs: remove the extra_refs API
>From my reading, all of these patches look good. Thanks for a
well-organized series.
-Peff
Previous: mhagger@alum.mit.edu
Message 14 of 14 in “Make alternates affect fetch behavior”
  1. 0/7 Make alternates affect fetch behaviormhagger@alum.mit.edu, Feb 11, 2012
  2. 1/7 t5700: document a failure of alternates to affect fetchmhagger@alum.mit.edu, Feb 11, 2012
  3. Junio C HamanoFeb 13, 2012
  4. Michael HaggertyFeb 13, 2012
  5. 2/7 clone.c: move more code into the "if (refs)" conditionalmhagger@alum.mit.edu, Feb 11, 2012
  6. Junio C HamanoFeb 13, 2012
  7. 3/7 fetch-pack.c: rename some parameters from "path" to "refname"mhagger@alum.mit.edu, Feb 11, 2012
  8. Junio C HamanoFeb 13, 2012
  9. 4/7 fetch-pack.c: inline insert_alternate_refs()mhagger@alum.mit.edu, Feb 11, 2012
  10. 5/7 everything_local(): mark alternate refs as completemhagger@alum.mit.edu, Feb 11, 2012
  11. 6/7 clone: do not add alternate references to extra_refsmhagger@alum.mit.edu, Feb 11, 2012
  12. Junio C HamanoFeb 13, 2012
  13. 7/7 refs: remove the extra_refs APImhagger@alum.mit.edu, Feb 11, 2012
  14. Jeff KingFeb 14, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.