Re: [PATCH 0/2] git-p4: fix submit regression with --use-client-spec
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 27, 2012, 00:18 UTC
- Message-ID
- <7vhaydcenz.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1330218385-22309-1-git-send-email-pw@padd.com>
Pete Wyckoff <pw@padd.com> writes:
Show 12 quoted lines
> This pair of patches fixes a regression that happened with ecb7cf9 > (git-p4: rewrite view handling, 2012-01-02). There are two factors that > affect where files go in the client when submitting: the cilent spec, > and the depot path. When the depot path was not exactly the root of > the client, submit fails. > > Fix this by always using the true client root. And also notice that > somebody has to tell the submit path that it should be looking at the > cilent spec. Save useClientSpec in a configuration variable if it > was specified as an option on the command line. > > Junio: can you put this on maint to go out with the next 1.9.x?
Surely and thanks.
Your "p4: submit with wildcards" seems to conflict with this change and may need to be rebased, though.
Show 9 quoted lines
> > Pete Wyckoff (2): > git-p4: set useClientSpec variable on initial clone > git-p4: fix submit regression with clientSpec and subdir clone > > Documentation/git-p4.txt | 10 ++- > contrib/fast-import/git-p4 | 97 ++++++++++++++++--------- > t/t9809-git-p4-client-view.sh | 159 ++++++++++++++++++++++++++++++++++++++--- > 3 files changed, 219 insertions(+), 47 deletions(-)