git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] git-p4: fix submit regression with --use-client-spec

From
PWPete Wyckoff <pw@padd.com>
Date
Feb 26, 2012, 01:06 UTC
Message-ID
<1330218385-22309-1-git-send-email-pw@padd.com>

This pair of patches fixes a regression that happened with ecb7cf9 (git-p4: rewrite view handling, 2012-01-02). There are two factors that affect where files go in the client when submitting: the cilent spec, and the depot path. When the depot path was not exactly the root of the client, submit fails.

Fix this by always using the true client root. And also notice that somebody has to tell the submit path that it should be looking at the cilent spec. Save useClientSpec in a configuration variable if it was specified as an option on the command line.

Junio: can you put this on maint to go out with the next 1.9.x?
Pete Wyckoff (2):
  git-p4: set useClientSpec variable on initial clone
  git-p4: fix submit regression with clientSpec and subdir clone
 Documentation/git-p4.txt      |   10 ++-
 contrib/fast-import/git-p4    |   97 ++++++++++++++++---------
 t/t9809-git-p4-client-view.sh |  159 ++++++++++++++++++++++++++++++++++++++---
 3 files changed, 219 insertions(+), 47 deletions(-)
-- 
1.7.9.219.g1d56c.dirty
Next: Pete Wyckoff
Message 1 of 5 in “git-p4: fix submit regression with --use-client-spec”
  1. 0/2 git-p4: fix submit regression with --use-client-specPete Wyckoff, Feb 26, 2012
  2. 1/2 git-p4: set useClientSpec variable on initial clonePete Wyckoff, Feb 26, 2012
  3. 2/2 git-p4: fix submit regression with clientSpec and subdir clonePete Wyckoff, Feb 26, 2012
  4. Junio C HamanoFeb 27, 2012
  5. Pete WyckoffFeb 27, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.