git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fix incorrect line number report for bad gitconfig

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 12, 2012, 05:55 UTC
Message-ID
<7vhaxuuzvt.fsf@alter.siamese.dyndns.org>
In-Reply-To
<7v8vj94c1a.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 14 quoted lines
> Martin Stenberg <martin@gnutiken.se> writes:
>
>> From c88f00e06cb877f9d944fdec480f53a7a42dd990 Mon Sep 17 00:00:00 2001
>> From: Martin Stenberg <martin@gnutiken.se>
>> Date: Fri, 9 Mar 2012 22:57:54 +0100
>> Subject: [PATCH] fix incorrect line number report for bad gitconfig
>
> Please drop these four lines. The commit object name is no use to
> me, and the other lines duplicate what you have in the mail header.
> ...
> Please have a paragraph break before your S-o-b: line.
>
> Thanks. Review of the patch text follows.
> ...

Also could you add a couple of tests (you identified two cases in your log message) to make sure this fix will not be broken in the future, perhaps to t1300?

Thanks.
Previous: Junio C HamanoNext: Martin Stenberg
Message 3 of 4 in “fix incorrect line number report for bad gitconfig”
  1. fix incorrect line number report for bad gitconfigMartin Stenberg, Mar 9, 2012
  2. Junio C HamanoMar 9, 2012
  3. Junio C HamanoMar 12, 2012
  4. Martin StenbergMar 12, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.