From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 12 Mar 2012 05:55:34 GMT
Subject: Re: [PATCH] fix incorrect line number report for bad gitconfig
Message-ID: <7vhaxuuzvt.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7v8vj94c1a.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> Martin Stenberg <martin@gnutiken.se> writes:
>
>> From c88f00e06cb877f9d944fdec480f53a7a42dd990 Mon Sep 17 00:00:00 2001
>> From: Martin Stenberg <martin@gnutiken.se>
>> Date: Fri, 9 Mar 2012 22:57:54 +0100
>> Subject: [PATCH] fix incorrect line number report for bad gitconfig
>
> Please drop these four lines. The commit object name is no use to
> me, and the other lines duplicate what you have in the mail header.
> ...
> Please have a paragraph break before your S-o-b: line.
>
> Thanks. Review of the patch text follows.
> ...

Also could you add a couple of tests (you identified two cases in
your log message) to make sure this fix will not be broken in the
future, perhaps to t1300?

Thanks.