Re: Notes in format-patch
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 13, 2012, 16:29 UTC
- Message-ID
- <7vhaotfou6.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <50A2213B.4060505@drmicha.warpmail.net>
Michael J Gruber <git@drmicha.warpmail.net> writes:
Show 21 quoted lines
> Michael J Gruber venit, vidit, dixit 12.11.2012 15:18: >> 'git replace' parses the revision arguments when it creates replacements >> (so that a sha1 can be abbreviated, e.g.) but not when deleting >> replacements. >> >> Make it parse the argument to 'replace -d' in the same way. >> >> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net> >> --- >> >> Notes: >> v3 safeguards the hex buffer against reuse >> builtin/replace.c | 16 ++++++++++------ >> t/t6050-replace.sh | 11 +++++++++++ >> 2 files changed, 21 insertions(+), 6 deletions(-) >> >> diff --git a/builtin/replace.c b/builtin/replace.c > > By the way - Junio, is that the intented outcome of "format-patch > --notes"? I would rather put the newline between the note and the > diffstat...
I do not mind (actually I personally would prefer to see) a blank line between the three-dash and "Notes:", but I agree that we should have a blank line before the diffstat block.