Re: Notes in format-patch

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Nov 14, 2012, 09:17 UTC
Message-ID: <50A361BD.2010806@drmicha.warpmail.net>
In-Reply-To: <7vfw4de5oc.fsf@alter.siamese.dyndns.org>

Junio C Hamano venit, vidit, dixit 13.11.2012 19:09:

Show 22 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
>> ... and it is broken X-<.
>>
>> The blank line should be added before the diffstat, not after the
>> notes message (t3307 shows a case where we give notes without
>> diffstat, and we shouldn't be adding an extra blank line in that
>> case.
> 
> Second try.
> 
> -- >8 --
> Subject: format-patch: add a blank line between notes and diffstat
> 
> The last line of the note text comes immediately before the diffstat
> block, making the latter unnecessarily harder to view.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> 
>  log-tree.c | 31 +++++++++++++++++++++----------
>  1 file changed, 21 insertions(+), 10 deletions(-)

Thanks, that patch works. I'm curious, though, where the empty line between the --- and your diffstat comes from. Do you have an empty note? I'm not getting any (origin/next+your patch).

The fact that we don't usually have that empty line was the reason why I preferred to have no empty line between the --- and the "Note:".

Michael