Re: [RFC] Instruct git-completion.bash that we are in test mode

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 22, 2013, 04:31 UTC
Message-ID: <7vham9dej2.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130122003954.GA23297@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 15 quoted lines

> I really hate to suggest this, but should it be more like:
>
>   if test -z "$FAKE_COMMAND_LIST"; then
>           __git_cmdlist() {
>                   git help -a | egrep '^  [a-zA-Z0-9]'
>           }
>   else
>           __git_cmdlist() {
>                   printf '%s' "$FAKE_COMMAND_LIST"
>           }
>   fi
>
> That gives us a nice predictable starting point for actually testing the
> completion code. The downside is that it  doesn't let us test that we
> remain compatible with the output of "help -a".

Yeah, I think this is simpler and more to the point for the test in t9902. If we really want to test something that is the same as, or at least any closer than this approach (or my "help --standard"), to what the real users use, the test has to become inherently flaky, so I think we should go for the simplicity of this patch shows.