Re: [PATCH] t9902: protect test from stray build artifacts

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 25, 2013, 02:59 UTC
Message-ID: <20130125025910.GB26524@elie.Belkin>
In-Reply-To: <20130125011349.GB27657@sigill.intra.peff.net>

Jeff King wrote:

> On Thu, Jan 24, 2013 at 03:07:42PM -0800, Junio C Hamano wrote[1]:

>> Instrument the completion script and give it a way for us to tell
>> what (subset of) subcommands we are going to ship.

[...]

Show 7 quoted lines

> The only thing I might add is a test just to double-check that "git help
> -a" is parsed correctly. Like:
>
>   test_expect_success 'command completion works without test harness' '
>            GIT_TESTING_COMMAND_COMPLETION= run_completion "git bun" &&
>            grep "^bundle\$" out
>   '

Yes. Since there are no other 'git help -a' tests, I think we need this.

Aside from that, the fix looks good to me.

Jonathan

[1] http://thread.gmane.org/gmane.comp.version-control.git/214167/focus=214469