git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] t3600: test rm of path with changed leading symlinks

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 4, 2013, 23:12 UTC
Message-ID
<7vhajlgabi.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20130404210304.GA25811@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> Deleting across symlinks inside the repo can be brushed aside with "eh,
> well, it is just another way to mention the same name in the
> filesystem". But deleting anything outside of the repo seems actively
> wrong.

Yup, you finally caught up ;-) IIRC, such an outside repository target was the case people realized that "git add" shouldn't see across symlinks.

> Hmm. I think you have convinced me (or perhaps I have convinced myself)
> that we should generally not be crossing symlink boundaries in
> translating names between the filesystem and index. I still don't want
> to work on it, though. :)

That is OK. Just let's not etch a wrong behaviour in stone with that test.

Previous: Jeff KingNext: Jeff King
Message 13 of 18 in “Behavior of git rm”
  1. jpinheiroApr 3, 2013
  2. Jeff KingApr 3, 2013
  3. Junio C HamanoApr 3, 2013
  4. Jeff KingApr 3, 2013
  5. Jeff KingApr 4, 2013
  6. 1/3 rm: do not complain about d/f conflicts during deletionJeff King, Apr 4, 2013
  7. 2/3 t3600: test behavior of reverse-d/f conflictJeff King, Apr 4, 2013
  8. 3/3 t3600: test rm of path with changed leading symlinksJeff King, Apr 4, 2013
  9. Junio C HamanoApr 4, 2013
  10. Jeff KingApr 4, 2013
  11. Junio C HamanoApr 4, 2013
  12. Jeff KingApr 4, 2013
  13. Junio C HamanoApr 4, 2013
  14. Jeff KingApr 4, 2013
  15. Junio C HamanoApr 4, 2013
  16. Jeff KingApr 5, 2013
  17. Junio C HamanoApr 5, 2013
  18. Jeff KingApr 5, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.