Re: [PATCH] Fix grammar in the 1.8.3 release notes.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 29, 2013, 21:16 UTC
- Message-ID
- <7vhaipghpy.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <7vli81ghsf.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 28 quoted lines
> Marc Branchaud <marcnarc@xiplink.com> writes: > >> This started out as an attempt to make the backward compatibility notes >> more parsable, but then I just kept going... > > Thanks. > >> * "git bundle" did not like a bundle created using a commit without >> - any message as its one of the prerequistes. >> + any message, as it is one of the prerequistes. > > This is actually saying a different thing. > > When you create a bundle, you can say "you can only unbundle this in > a repository that has commit X", with "git bundle create $name ^X Y > Z". Such a commit X is called the bundle's prerequisite. You can > have more than one prerequisite, e.g. "... ^X ^W Y Z". > > But if you create a bundle by using a commit that does not have any > message as X (i.e. the bundle's prerequisite), the "git bundle" did > not like to read the resulting bundle output. > > So <a commit <without any message> as its (bundle's) one of the > prerequisites> is what the original wanted to say. The rewrite > makes it read like "For a commit, having a message is a requirement > to be used in a bundle", at least to me. > >> * "index-pack --fix-thin" used an uninitialized value to compute
Please disregard everything below this line; the message was sent unfinished by accident.