git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix grammar in the 1.8.3 release notes.

From
LFLukas Fleischer <git@cryptocrack.de>
Date
May 1, 2013, 08:24 UTC
Message-ID
<20130501082434.GA19771@blizzard>
In-Reply-To
<517FD505.9000706@xiplink.com>
On Tue, Apr 30, 2013 at 10:28:21AM -0400, Marc Branchaud wrote:
Show 36 quoted lines
> On 13-04-29 05:15 PM, Junio C Hamano wrote:
> > Marc Branchaud <marcnarc@xiplink.com> writes:
> > 
> >> This started out as an attempt to make the backward compatibility notes
> >> more parsable, but then I just kept going...
> > 
> > Thanks.
> > 
> >>   * "git bundle" did not like a bundle created using a commit without
> >> -   any message as its one of the prerequistes.
> >> +   any message, as it is one of the prerequistes.
> > 
> > This is actually saying a different thing.  
> > 
> > When you create a bundle, you can say "you can only unbundle this in
> > a repository that has commit X", with "git bundle create $name ^X Y
> > Z".  Such a commit X is called the bundle's prerequisite.  You can
> > have more than one prerequisite, e.g. "... ^X ^W Y Z".
> > 
> > But if you create a bundle by using a commit that does not have any
> > message as X (i.e. the bundle's prerequisite), the "git bundle" did
> > not like to read the resulting bundle output.
> > 
> > So <a commit <without any message> as its (bundle's) one of the
> > prerequisites> is what the original wanted to say.  The rewrite
> > makes it read like "For a commit, having a message is a requirement
> > to be used in a bundle", at least to me.
> 
> Thanks, I did get that wrong.
> 
> CC'ing Lukas, who wrote the relevant commit (5446e33f35).
> 
> How about:
> 
> * "git bundle" can create a bundle that has a commit without a message as
>   a prerequisite, but it could not work with such a bundle.
Looks fine to me.

Junio's version with the last part changed to "as one of its prerequisites" sounds also good to me (in both cases, however, note the missing "i" in "prerequisites").

A third suggestion:
    "git bundle" erroneously bailed out when parsing a valid bundle
    containing a prerequisite commit without a commit message.
> 
> 		M.
Previous: Marc BranchaudNext: Marc Branchaud
Message 11 of 16 in “[ANNOUNCE] Git v1.8.3-rc0”
  1. Junio C HamanoApr 27, 2013
  2. shawn wilsonApr 27, 2013
  3. Michael HaggertyApr 27, 2013
  4. Junio C HamanoApr 28, 2013
  5. John KeepingApr 27, 2013
  6. Junio C HamanoApr 29, 2013
  7. Fix grammar in the 1.8.3 release notes.Marc Branchaud, Apr 29, 2013
  8. Junio C HamanoApr 29, 2013
  9. Junio C HamanoApr 29, 2013
  10. Marc BranchaudApr 30, 2013
  11. Lukas FleischerMay 1, 2013
  12. Marc BranchaudMay 1, 2013
  13. Junio C HamanoMay 1, 2013
  14. Junio C HamanoApr 29, 2013
  15. Eric SunshineApr 30, 2013
  16. Phil HordApr 30, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.