Re: [PATCH] xdiff: Show function names in hunk headers.
- From
Junio C Hamano <junkio@cox.net>
- Date
- Mar 28, 2006, 05:54 UTC
- Message-ID
- <7vfyl3m7vy.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <11435126113456-git-send-email-mdw@distorted.org.uk>
Mark Wooding <mdw@distorted.org.uk> writes:
> The function names are parsed by a particularly stupid algorithm at the > moment: it just tries to find a line in the `old' file, from before the > start of the hunk, whose first character looks plausible. Still, it's > most definitely a start.
> + (isalpha((unsigned char)*rec) || /* identifier? */
> + *rec == '_' || /* also identifier? */
> + *rec == '(' || /* lisp defun? */
> + *rec == '#')) { /* #define? */GNU diff -p does "^[[:alpha:]$_]"; personally I think any line that does not begin with a whitespace is good enough. In either way, your patch is good. Thanks.