git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Reencode committer info to utf-8 before formatting mail header

From
Junio C Hamano <junkio@cox.net>
Date
Jan 13, 2007, 22:18 UTC
Message-ID
<7vfyaek1ub.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<7vr6tzogp4.fsf@assigned-by-dhcp.cox.net>

On this topic, along with the "format-patch" fix (which automatically makes "rebase without --merge" do the right thing because it is "format-patch piped to am" in essence), I have another commit to make "cherry-pick", "rebase --merge" and "commit -c/-C" do the right thing according to the commitencoding specified in the repository the new commit is being created.

The issue is that an existing commit might have come from a different repository or from the past when this repository had commitencoding that was different from the current value. Running "cat-file commit" to extract the old commit log message and feeding it directly to create the new commit would not work, because the value of commitencoding in this repository may be different.

This should not affect old encoding-unaware setup where people use _only_ a legacy encoding and do not bother to specify any commitencoding. In such a case, both input and output are the same and while we pretend both are UTF-8, we actually do not trigger conversion. To support such a configuration is one reason I did not actually take Johannes's suggestion to error out on an existing commit that does _not_ have encoding header but the contents does not look like a valid UTF-8.

The series is currently sitting in 'next'. If people do not see problem with it, I think it should go in v1.5.0.

Previous: Alex RiesenNext: David Kågedal
Message 16 of 18 in “Reencode committer info to utf-8 before formatting mail header”
  1. Reencode committer info to utf-8 before formatting mail headerDavid Kågedal, Jan 12, 2007
  2. Junio C HamanoJan 12, 2007
  3. Junio C HamanoJan 13, 2007
  4. Junio C HamanoJan 13, 2007
  5. Johannes SchindelinJan 13, 2007
  6. Junio C HamanoJan 13, 2007
  7. David KågedalJan 15, 2007
  8. Johannes SchindelinJan 16, 2007
  9. David KågedalJan 16, 2007
  10. Robin RosenbergJan 13, 2007
  11. Junio C HamanoJan 13, 2007
  12. David KågedalJan 15, 2007
  13. Alex RiesenJan 13, 2007
  14. Horst H. von BrandJan 14, 2007
  15. Alex RiesenJan 14, 2007
  16. Junio C HamanoJan 13, 2007
  17. David KågedalJan 15, 2007
  18. David KågedalJan 15, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.