git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Reencode committer info to utf-8 before formatting mail header

From
Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date
Jan 13, 2007, 12:23 UTC
Message-ID
<200701131323.53121.robin.rosenberg.lists@dewire.com>
In-Reply-To
<7vmz4nog5b.fsf@assigned-by-dhcp.cox.net>
lördag 13 januari 2007 02:43 skrev Junio C Hamano:
> Side note.  The previous patch does not help if your commit were
> made in non UTF-8 with not too recent git; the code assumes that
> commit messages without the new "encoding" headers are in UTF-8.

Wasn't there a repository option, "commitencoding"? I can't see it being used here. I.e., we should err out if the log message is not UTF-8 and the option is not set (giving a message telling the user to set it). If it is set we should consider the repository encoding to be the one and if that too is wrong (only possible to detect for some encodings), just assume iso-8859-1 as anything could in theory be iso-8859-1 encoded. 

-- robin
Previous: David KågedalNext: Junio C Hamano
Message 10 of 18 in “Reencode committer info to utf-8 before formatting mail header”
  1. Reencode committer info to utf-8 before formatting mail headerDavid Kågedal, Jan 12, 2007
  2. Junio C HamanoJan 12, 2007
  3. Junio C HamanoJan 13, 2007
  4. Junio C HamanoJan 13, 2007
  5. Johannes SchindelinJan 13, 2007
  6. Junio C HamanoJan 13, 2007
  7. David KågedalJan 15, 2007
  8. Johannes SchindelinJan 16, 2007
  9. David KågedalJan 16, 2007
  10. Robin RosenbergJan 13, 2007
  11. Junio C HamanoJan 13, 2007
  12. David KågedalJan 15, 2007
  13. Alex RiesenJan 13, 2007
  14. Horst H. von BrandJan 14, 2007
  15. Alex RiesenJan 14, 2007
  16. Junio C HamanoJan 13, 2007
  17. David KågedalJan 15, 2007
  18. David KågedalJan 15, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.