Re: [PATCH] config: read system-wide defaults from /etc/gitconfig

From: Junio C Hamano <junkio@cox.net>
Date: Feb 14, 2007, 19:43 UTC
Message-ID: <7vfy98o78i.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.63.0702142015150.22628@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 11 quoted lines

>> Stupid probably is too strong a word, but I think I'd agree we
>> should default it to $(prefix)/etc and have distros override it
>> in the Makefile.
>
> Fair enough. And my patch was not really complete. Please amend to spare 
> me eternal shame:
> --
> [BROWN PAPERBAG PATCH ON TOP OF OTHER PATCH] 
>
> It is $prefix/etc/gitconfig now, and works also if you do not
> `git config -l`. D'oh.

How would we run our tests without getting screwed by whatever non-standard values system-wide configuration may have? Currently we disable tester's ~/.gitconfig by exporting HOME from t/test-lib.sh, but that will not work for this.

I think we need to have a way to disable this setting, perhaps via an environment variable.

I do not think we need to support 'git config --system --set foo.bar baz' but some people might have twisted minds ;-).