Re: [PATCH] config: read system-wide defaults from /etc/gitconfig

From: Han-Wen Nienhuys <hanwen@xs4all.nl>
Date: Feb 14, 2007, 18:10 UTC
Message-ID: <45D35092.8040901@xs4all.nl>
In-Reply-To: <Pine.LNX.4.63.0702141246160.22628@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin escreveu:

> The settings in /etc/gitconfig can be overridden in ~/.gitconfig,
> which in turn can be overridden in .git/config.

> +#define ETC_GITCONFIG "/etc/gitconfig"

> +		if (!access(ETC_GITCONFIG, R_OK))
> +			ret += git_config_from_file(fn, ETC_GITCONFIG);

this is a stupid idea.

This should use the path given as the --sysconfdir argument to configure. If the configure result is not available, it should default to $prefix/etc/

It should be possible to install private copy of Git without being affected by system wide defaults.

-- 
 Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen