Re: [PATCH/RFC 2/2] Provide a build time default-editor setting

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 29, 2009, 22:12 UTC
Message-ID: <7vfx916ea6.fsf@alter.siamese.dyndns.org>
In-Reply-To: <200910292157.37474.j.sixt@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

Show 5 quoted lines

> Yeah, whatever, I didn't take the time to think it through. But this may be an 
> opportunity to give some life back to the zombie that git-var currently is, 
> that is, to make it the plumbing that does value discovery for variables like 
> GIT_AUTHOR_INDENT, GIT_COMMITTER_IDENT, GIT_EDITOR, and perhaps also 
> GIT_PAGER.

Hmm, wouldn't it make even more sense to "run" them for the calling Porcelain script?

A shell script Porcelain can already ". git-sh-setup" and say

	git_editor this-file

when it needs to spawn the editor of choice. Your new plumbing support could make the definition of git_editor in git-sh-setup.sh into something like:

    git_editor() {
    	git var --run GIT_EDITOR "$@"
    }
    git_pager() {
    	git var --run GIT_PAGER "$@"
    }