[PATCH 1/2] Provide a build time default-pager setting
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Oct 29, 2009, 07:45 UTC
- Message-ID
- <20091029074532.GB15403@progeny.tock>
- In-Reply-To
- <20091029073224.GA15403@progeny.tock>
From: Junio C Hamano <gitster@pobox.com>
On (old) solaris systems, /usr/bin/less (typically the first less found) doesn't understand the default arguments (FXRS), which forces users to alter their environment (PATH, GIT_PAGER, LESS, etc) or have a local or global gitconfig before paging works as expected.
On Debian systems, by policy packages must fall back to the 'pager' command, so that changing the target of the /usr/bin/pager symlink changes the default pager for all packages at once.
Provide a DEFAULT_PAGER knob so packagers can set the fallback pager to something appropriate during the build.
This puts the "less" default in the Makefile instead of pager.c, since it is needed for git-svn, too. This means that the DEFAULT_PAGER preprocessor token _has_ to be defined on the command line for git to build. I was worried about this for a moment, but GIT_VERSION already works this way without trouble.
Probably the DEFAULT_PAGER setting should be added to something like TRACK_CFLAGS as well. Actually, some other settings that can change without forcing files to be rebuilt (e.g. SHELL_PATH), too. This should be probably be addressed separately.
Reported-by: Ben Walton <bwalton@artsci.utoronto.ca> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> --- Makefile | 8 ++++++++ git-svn.perl | 5 +++-- pager.c | 2 +- 3 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile index 268aede..fc1a461 100644 --- a/Makefile +++ b/Makefile @@ -200,6 +200,9 @@ all:: # memory allocators with the nedmalloc allocator written by Niall Douglas. # # Define NO_REGEX if you have no or inferior regex support in your C library. +# +# Define DEFAULT_PAGER to the path of a sensible pager (defaults to "less") if +# you want to use something different. GIT-VERSION-FILE: .FORCE-GIT-VERSION-FILE @$(SHELL_PATH) ./GIT-VERSION-GEN @@ -1294,6 +1297,10 @@ ifdef NO_REGEX COMPAT_CFLAGS += -Icompat/regex COMPAT_OBJS += compat/regex/regex.o endif +ifndef DEFAULT_PAGER + DEFAULT_PAGER = less +endif +BASIC_CFLAGS += -DDEFAULT_PAGER='"$(DEFAULT_PAGER)"' ifdef USE_NED_ALLOCATOR COMPAT_CFLAGS += -DUSE_NED_ALLOCATOR -DOVERRIDE_STRDUP -DNDEBUG -DREPLACE_SYSTEM_ALLOCATOR -Icompat/nedmalloc @@ -1451,6 +1458,7 @@ $(patsubst %.perl,%,$(SCRIPT_PERL)): % : %.perl -e '}' \ -e 's|@@INSTLIBDIR@@|'"$$INSTLIBDIR"'|g' \ -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' \ + -e 's/@@DEFAULT_PAGER@@/$(DEFAULT_PAGER)/g' \ $@.perl >$@+ && \ chmod +x $@+ && \ mv $@+ $@ diff --git a/git-svn.perl b/git-svn.perl index 6a3b501..c270b23 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -3,11 +3,12 @@ # License: GPL v2 or later use warnings; use strict; -use vars qw/ $AUTHOR $VERSION +use vars qw/ $AUTHOR $VERSION $DEFAULT_PAGER $sha1 $sha1_short $_revision $_repository $_q $_authors $_authors_prog %users/; $AUTHOR = 'Eric Wong <normalperson@yhbt.net>'; $VERSION = '@@GIT_VERSION@@'; +$DEFAULT_PAGER = '@@DEFAULT_PAGER@@'; # From which subdir have we been invoked? my $cmd_dir_prefix = eval { @@ -5174,7 +5175,7 @@ sub git_svn_log_cmd { sub config_pager { $pager ||= $ENV{GIT_PAGER} || $ENV{PAGER}; if (!defined $pager) { - $pager = 'less'; + $pager = $DEFAULT_PAGER; } elsif (length $pager == 0 || $pager eq 'cat') { $pager = undef; } diff --git a/pager.c b/pager.c index 86facec..416a796 100644 --- a/pager.c +++ b/pager.c @@ -58,7 +58,7 @@ void setup_pager(void) if (!pager) pager = getenv("PAGER"); if (!pager) - pager = "less"; + pager = DEFAULT_PAGER; else if (!*pager || !strcmp(pager, "cat")) return;
-- 1.6.5.2