git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH RESEND] Explicitly truncate bswap operand to uint32_t

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 23, 2009, 00:16 UTC
Message-ID
<7vfx86aydh.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4B03FC57.5000506@googlemail.com>
Benjamin Kramer <benny.kra@googlemail.com> writes:
Show 7 quoted lines
> There are some places in git where a long is passed to htonl/ntohl. llvm
> doesn't support matching operands of different bitwidths intentionally.
> This patch fixes the build with llvm-gcc (and clang) on x86_64.
>
> Signed-off-by: Benjamin Kramer <benny.kra@googlemail.com>
> ---
> Any comments on this patch?

My vague recollection is that the response was "we do not mind it per-se, unless it ends up in an ugly change; but we would prefer if you go fix your compiler", but maybe I read it on lkml not here?

Also my vague recollection is that the kernel folks took that patch in the end, so I think it is Ok for us to take this patch, too.

Previous: Benjamin Kramer
Message 2 of 2 in “Explicitly truncate bswap operand to uint32_t”
  1. Explicitly truncate bswap operand to uint32_tBenjamin Kramer, Nov 18, 2009
  2. Junio C HamanoNov 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.