From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 23 Nov 2009 00:16:58 GMT
Subject: Re: [PATCH RESEND] Explicitly truncate bswap operand to uint32_t
Message-ID: <7vfx86aydh.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4B03FC57.5000506@googlemail.com>

Benjamin Kramer <benny.kra@googlemail.com> writes:

> There are some places in git where a long is passed to htonl/ntohl. llvm
> doesn't support matching operands of different bitwidths intentionally.
> This patch fixes the build with llvm-gcc (and clang) on x86_64.
>
> Signed-off-by: Benjamin Kramer <benny.kra@googlemail.com>
> ---
> Any comments on this patch?

My vague recollection is that the response was "we do not mind it per-se,
unless it ends up in an ugly change; but we would prefer if you go fix
your compiler", but maybe I read it on lkml not here?

Also my vague recollection is that the kernel folks took that patch in the
end, so I think it is Ok for us to take this patch, too.