Re: [PATCH] Makefile: Use $(sharedir)/gitweb for target 'install-gitweb'

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 2, 2010, 04:31 UTC
Message-ID: <7vfx16qcmm.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201006012150.02970.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

Show 17 quoted lines

> On Tue, 1 June 2010, Pavan Kumar Sunkara wrote:
>
>> Export gitwebdir variable so that when user types the command
>> 'make install-gitweb', gitweb is installed in $(sharedir)/gitweb
>> rather than /var/www/cgi-bin. Now, $(sharedir)/gitweb is default
>> for both 'install' and 'install-gitweb' targets.
>> 
>> Remove 'gitwebdir=$(gitwebdir_SQ)' from gitweb part of 'install'
>> target which is unneccessary now.
>> 
>> Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
>
> For what it is worth:
>
> Acked-by: Jakub Narebski <jnareb@gmail.com>
>
> (But I have not tested it!)

I am wondering if we would also want to do something with this line

    gitwebdir ?= /var/www/cgi-bin

in gitweb/Makefile. This is orthogonal to the patch under discussion does, though.