Re: [PATCH] Makefile: Use $(sharedir)/gitweb for target 'install-gitweb'
On Tue, 1 June 2010, Pavan Kumar Sunkara wrote:
Show 9 quoted lines
> Export gitwebdir variable so that when user types the command
> 'make install-gitweb', gitweb is installed in $(sharedir)/gitweb
> rather than /var/www/cgi-bin. Now, $(sharedir)/gitweb is default
> for both 'install' and 'install-gitweb' targets.
>
> Remove 'gitwebdir=$(gitwebdir_SQ)' from gitweb part of 'install'
> target which is unneccessary now.
>
> Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
For what it is worth:
Acked-by: Jakub Narebski <jnareb@gmail.com>
(But I have not tested it!)
Show 14 quoted lines
> ---
> Makefile | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 8f011a5..32e3146 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -294,7 +294,7 @@ lib = lib
> # DESTDIR=
> pathsep = :
>
> -export prefix bindir sharedir sysconfdir
> +export prefix bindir sharedir gitwebdir sysconfdir
Nitpick: why not
+export prefix bindir sharedir sysconfdir gitwebdir
i.e. have 'gitwebdir' last? Not that it matters, though....
Show 9 quoted lines
>
> CC = gcc
> AR = ar
> @@ -2049,7 +2049,7 @@ install: all
> $(MAKE) -C templates DESTDIR='$(DESTDIR_SQ)' install
> ifndef NO_PERL
> $(MAKE) -C perl prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' install
> - $(MAKE) -C gitweb gitwebdir=$(gitwebdir_SQ) install
> + $(MAKE) -C gitweb install
Show 7 quoted lines
> endif
> ifndef NO_PYTHON
> $(MAKE) -C git_remote_helpers prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' install
> --
> 1.7.1.447.g40f7.dirty
>
>
--
Jakub Narebski
Poland
Jakub Narebski <jnareb@gmail.com>