Re: [PATCH v4 1/5] fmt-merge-msg: Make the number of log entries in commit message configurable

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 22, 2010, 05:05 UTC
Message-ID: <7vfwy78cfl.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100822033330.GA12380@belmont.cs.uchicago.edu>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 19 quoted lines

> FWIW if I were writing it, I would make changes in something like this
> order:
>
>  - Change fmt_merge_msg API to
>
> 	int fmt_merge_msg(struct strbuf *in, struct strbuf *out,
> 				int shortlog_len);
>
>    where shortlog_len is 0 for no shortlog, 20 for a shortlog
>    with 20 items.  Update all callers (the changed function
>    signature makes it easy to find them).
>
>  - Update merge --log and fmt-merge-msg --log options to take
>    an optional "size of shortlog" argument.
>
>  - update [merge] log configuration to accept an integer
>    "size of shortlog" value.
>
> The first step might look like this.

Thanks; it is very pleasing to see a more experienced contributor mentoring another with a good example to show _how_ the design of a new feature should be done.