Re: [PATCH v4 1/5] fmt-merge-msg: Make the number of log entries in commit message configurable

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Aug 22, 2010, 06:53 UTC
Message-ID: <20100822065331.GA15561@kytes>
In-Reply-To: <20100822033330.GA12380@belmont.cs.uchicago.edu>

Hi Jonathan,

Jonathan Nieder writes:

Show 10 quoted lines

> Hi again,
> 
> Thanks for working on this.
> 
> Ramkumar Ramachandra wrote:
> 
> > Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> > Reported-by: Yaroslav Halchenko <debian <at> onerussian.com>
> 
> Looks like some of the @ signs have been corrupted somehow.

My stupidity- I copied the additional lines off the GMane interface.

[...]

Show 19 quoted lines

> FWIW if I were writing it, I would make changes in something like this
> order:
> 
>  - Change fmt_merge_msg API to
> 
> 	int fmt_merge_msg(struct strbuf *in, struct strbuf *out,
> 				int shortlog_len);
> 
>    where shortlog_len is 0 for no shortlog, 20 for a shortlog
>    with 20 items.  Update all callers (the changed function
>    signature makes it easy to find them).
> 
>  - Update merge --log and fmt-merge-msg --log options to take
>    an optional "size of shortlog" argument.
> 
>  - update [merge] log configuration to accept an integer
>    "size of shortlog" value.
> 
> The first step might look like this.

[...]

Thanks for being so patient! It looks like there's no end to my mistakes :p

I'll rewrite this and try to follow the guidelines you've outlined in future- hopefully, I'll become more experienced someday :)

-- Ram