Re: What's cooking in git.git (Dec 2010, #06; Tue, 21)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 23, 2010, 17:17 UTC
- Message-ID
- <7vfwto2ytb.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <AANLkTinH0h5euL=_wMpGirVEEYgoA9hXGhKGja9oPa2j@mail.gmail.com>
Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
Show 16 quoted lines
> On Wed, Dec 22, 2010 at 8:59 AM, Junio C Hamano <gitster@pobox.com> wrote: >> * nd/struct-pathspec (2010-12-15) 21 commits >> ... >> (this branch is used by en/object-list-with-pathspec.) >> >> Rerolled again. Getting nicer by the round ;-) > > With jj/icase-directory merged to master, match_pathspec() and > match_pathspec_depth() now diverse again. > > When I wrote match_pathspec_depth(), I assumed that match_pathspec() > would not change much and I would have more time for converting the > rest of git to use match_*_depth(). Looks like I need to add case > insensitive matching to struct pathspec and friends then remove > match_pathspec() in this series too. At least if somebody changes > match_pathspec() again, it would cause a conflict so I can catch it.
While this topic is something I have long wanted to see, I have started feeling that this needs to cook a bit longer than be in the next release. So perhaps the best course of action might be to rebase the series once after the 1.7.4 feature freeze, cook it in 'next' for a while and make it part of the release after that. I think at that point we may probably want to have other changes that are not strictly backward compatible but their incompatibilities do not matter in practice (e.g. cquoting pathspecs in the attributes file comes to mind, but I am sure there will be other changes that people wanted to have but we held them off due to worries on compatibility).
What do you think?