git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] .gitattributes: Enable cpp diff parsing for .[ch] files

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 26, 2011, 20:54 UTC
Message-ID
<7vfwkndhc4.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CA+55aFxNXK-AJdrHBBycM5W632qUBi4E=jangcdRoefQiHzbug@mail.gmail.com>
Linus Torvalds <torvalds@linux-foundation.org> writes:
Show 12 quoted lines
> On Thu, Aug 25, 2011 at 3:37 PM, Boaz Harrosh <bharrosh@panasas.com> wrote:
>>
>> Add a .gitattributes file to the Linux tree to enable cpp parsing
>> of the source files.
>
> Hmm. I'm not entirely conviced. If people really think that the hunk
> description matters that much, maybe we should just instead improve on
> the automatic diff detection, and extend it from just binary-vs-text,
> to also do the common hunk-headers.
>
> After all, not having a diff pattern already *does* mean "automatic",
> so it would be just a rather trivial extension to that.

Not quite sure what you exactly mean by "extend it from just binary-vs-text". Do you mean update buffer_is_binary() and add source language detection?

See also:
    http://thread.gmane.org/gmane.comp.version-control.git/180103/focus=180113
Previous: Linus TorvaldsNext: Linus Torvalds
Message 3 of 10 in “.gitattributes: Enable cpp diff parsing for .[ch] files”
  1. .gitattributes: Enable cpp diff parsing for .[ch] filesBoaz Harrosh, Aug 25, 2011
  2. Linus TorvaldsAug 26, 2011
  3. Junio C HamanoAug 26, 2011
  4. Linus TorvaldsAug 26, 2011
  5. Boaz HarroshAug 26, 2011
  6. Peter ZijlstraAug 29, 2011
  7. Boaz HarroshAug 29, 2011
  8. Peter ZijlstraAug 29, 2011
  9. Linus TorvaldsAug 29, 2011
  10. Boaz HarroshAug 29, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.