Re: [PATCH] .gitattributes: Enable cpp diff parsing for .[ch] files

From: Boaz Harrosh <bharrosh@panasas.com>
Date: Aug 26, 2011, 20:55 UTC
Message-ID: <4E580830.4010305@panasas.com>
In-Reply-To: <CA+55aFxNXK-AJdrHBBycM5W632qUBi4E=jangcdRoefQiHzbug@mail.gmail.com>

On 08/26/2011 01:27 PM, Linus Torvalds wrote:

Show 15 quoted lines

> On Thu, Aug 25, 2011 at 3:37 PM, Boaz Harrosh <bharrosh@panasas.com> wrote:
>>
>> Add a .gitattributes file to the Linux tree to enable cpp parsing
>> of the source files.
> 
> Hmm. I'm not entirely conviced. If people really think that the hunk
> description matters that much, maybe we should just instead improve on
> the automatic diff detection, and extend it from just binary-vs-text,
> to also do the common hunk-headers.
> 
> After all, not having a diff pattern already *does* mean "automatic",
> so it would be just a rather trivial extension to that.
> 
> Junio?
>

There was a patch submitted for new git version to auto detect file
extensions and do the right thing. 
(Look for the thread "git diff annoyance / feature request" on the git
 mailing list)

But this patch is for all the people and distributions that are going to use the old git versions for a while, (Years).

It is important for the Linux mailing-list review, because you get patches with:

@@@ lable out: - change foo + to bazz

And how the hell are you suppose to know where in the file it is. This is such a trivial addition, that can help unify everyone's usage. I don't see the down sides.

Thanks Boaz

>                      Linus