Re: [PATCH v2 3/6] vcs-svn: prefer constcmp to prefixcmp

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 1, 2012, 16:27 UTC
Message-ID: <7vfwaf3sll.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1338475290-22644-4-git-send-email-davidbarr@google.com>

David Barr <davidbarr@google.com> writes:

> Comparisons in svndump.c are always guarded by length.
> As a bonus, elimate dependency on prefixcmp for upstream.
>
> Signed-off-by: David Barr <davidbarr@google.com>

It feels suboptimal, from cross-project maintenance point of view, that "do not use prefixcmp() in the source in this directory" has to be an unwritten rule. Is there something we can do better to avoid having to apply a patch like this in the future?

Show 16 quoted lines

>  vcs-svn/svndump.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vcs-svn/svndump.c b/vcs-svn/svndump.c
> index 0899790..8d0ae9c 100644
> --- a/vcs-svn/svndump.c
> +++ b/vcs-svn/svndump.c
> @@ -361,7 +361,7 @@ void svndump_read(const char *url)
>  			reset_rev_ctx(atoi(val));
>  			break;
>  		case sizeof("Node-path"):
> -			if (prefixcmp(t, "Node-"))
> +			if (constcmp(t, "Node-"))
>  				continue;
>  			if (!constcmp(t + strlen("Node-"), "path")) {
>  				if (active_ctx == NODE_CTX)