git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/6] vcs-svn: fix clang-analyzer error

From
David Barr <davidbarr@google.com>
Date
May 31, 2012, 14:41 UTC
Message-ID
<1338475290-22644-2-git-send-email-davidbarr@google.com>
In-Reply-To
<1338475290-22644-1-git-send-email-davidbarr@google.com>
vcs-svn/svndiff.c:298:3: warning: Assigned value is garbage or undefined
                off_t pre_off = pre_off; /* stupid GCC... */
                ^               ~~~~~~~
Signed-off-by: David Barr <davidbarr@google.com>
---
 vcs-svn/svndiff.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vcs-svn/svndiff.c b/vcs-svn/svndiff.c
index 1647c1a..57d647d 100644
--- a/vcs-svn/svndiff.c
+++ b/vcs-svn/svndiff.c
@@ -295,7 +295,7 @@ int svndiff0_apply(struct line_buffer *delta, off_t delta_len,
 	if (read_magic(delta, &delta_len))
 		return -1;
 	while (delta_len) {	/* For each window: */
-		off_t pre_off = pre_off; /* stupid GCC... */
+		off_t pre_off = 0; /* stupid GCC and clang-analyzer... */
 		size_t pre_len;
 
 		if (read_offset(delta, &pre_off, &delta_len) ||
-- 
1.7.10.2
Previous: David BarrNext: David Barr
Message 2 of 10 in “vcs-svn: housekeeping”
  1. 0/6 vcs-svn: housekeepingDavid Barr, May 31, 2012
  2. 1/6 vcs-svn: fix clang-analyzer errorDavid Barr, May 31, 2012
  3. 2/6 vcs-svn: simplify cleanup in apply_one_window()David Barr, May 31, 2012
  4. 3/6 vcs-svn: prefer constcmp to prefixcmpDavid Barr, May 31, 2012
  5. Junio C HamanoJun 1, 2012
  6. David Michael BarrJun 1, 2012
  7. 4/6 vcs-svn: prefer strstr over memmemDavid Barr, May 31, 2012
  8. 5/6 vcs-svn: fix signedness warningsDavid Barr, May 31, 2012
  9. 6/6 vcs-svn: drop no-op reset methodsDavid Barr, May 31, 2012
  10. David Michael BarrJun 1, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.