Re: [PATCH] Highlight keyboard shortcuts in git-add--interactive

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 2, 2007, 19:06 UTC
Message-ID: <7veje4ykzg.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <5B4BC281-10BD-437F-A956-EEB73F40A76C@wincent.com>

Wincent Colaiuta <win@wincent.com> writes:

> Unless by "documentation" you meant to somehow expose these in the  
> interface at runtime... something like this? (applied on top of the  
> patch I just sent to the list):

I did not recall (and was too lazy to check) if they were documented already, but as you suggest, I think letting people type ? at the prompt to get a help is always a good idea. So, instead of doing this part:

Show 6 quoted lines

> @@ -308,7 +309,7 @@ sub list_and_choose {
>   			print "> ";
>   		}
>   		else {
> -			print ">> ";
> +			print " (?)>> ";

I'd prefer accepting '?' as a valid "help me" input and showing appropriate help for _both_ singleton select and multiple select, without mentioning " (?)". For this, your prompt_help_cmd needs to be enhanced to limit the help to singleton case, though.