Re: [PATCH 1/2] Highlight keyboard shortcuts in git-add--interactive

From: Wincent Colaiuta <win@wincent.com>
Date: Dec 1, 2007, 14:15 UTC
Message-ID: <697AB37F-784D-4374-A290-0E6290712B29@wincent.com>
In-Reply-To: <1196518040-85584-1-git-send-email-win@wincent.com>

El 1/12/2007, a las 15:07, Wincent Colaiuta escribió:

Show 10 quoted lines

> +# filters out prefixes which have special meaning to  
> list_and_choose()
> +sub is_valid_prefix {
> +	my $prefix = shift;
> +	my $valid = (defined $prefix) &&
> +	    !($prefix =~ /[\s,]/) && # separators
> +	    !($prefix =~ /^-/) &&    # deselection
> +	    !($prefix =~ /^\d+/) &&  # selection
> +	    ($prefix ne '*');        # "all" wildcard
> +}

Doh, that's supposed to be:

	return (defined $prefix)...

Not:

	my $valid = (defined $prefix)...

It actually works as is, but I had changed the "return" while working on the patch (for debugging) and forgot to change it back afterwards.

And yes, I did proofread the patch before sending it. I just didn't notice the first time around.

Cheers, Wincent