git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] xdiff-interface.c (buffer_is_binary): Remove buffer size limitation

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 3, 2007, 23:24 UTC
Message-ID
<7veje3e4zn.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20071203215007.GA14697@basalt.office.altlinux.org>
"Dmitry V. Levin" <ldv@altlinux.org> writes:
Show 15 quoted lines
> On Sat, Dec 01, 2007 at 11:46:52AM -0800, Junio C Hamano wrote:
>> On Sat, Dec 01, 2007 at 07:01:13PM +0300, Dmitry V. Levin wrote:
>> 
>> > When checking buffer for NUL byte, do not limit size of buffer we check.
>> > Otherwise we break git-rebase: git-format-patch may generate output which
>> > git-mailinfo cannot handle properly.
>> 
>> I think this is tackling a valid problem but it is a wrong solution.
>> The change penalizes text changes which is the majority, just in case
>> there is an unusual change that has an embedded NUL far into the file
>> (iow, exception).
>
> Penalizes?
> Average file size in the linux-2.6.23.9 kernel tree is 10944 bytes,
> FIRST_FEW_BYTES limit is 8000 bytes.

I really wish we were living in a simpler time, back when I could just say "we optimize for the kernel" and did not have to be worried about getting laughed at.

Previous: Dmitry V. LevinNext: Linus Torvalds
Message 4 of 7 in “xdiff-interface.c (buffer_is_binary): Remove buffer size limitation”
  1. xdiff-interface.c (buffer_is_binary): Remove buffer size limitationDmitry V. Levin, Dec 1, 2007
  2. Junio C HamanoDec 1, 2007
  3. Dmitry V. LevinDec 3, 2007
  4. Junio C HamanoDec 3, 2007
  5. Linus TorvaldsDec 4, 2007
  6. Johannes SchindelinDec 4, 2007
  7. David KastrupDec 5, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.