Re: [PATCH] xdiff-interface.c (buffer_is_binary): Remove buffer size limitation

From: Dmitry V. Levin <ldv@altlinux.org>
Date: Dec 3, 2007, 21:50 UTC
Message-ID: <20071203215007.GA14697@basalt.office.altlinux.org>
In-Reply-To: <7vlk8e42qb.fsf@gitster.siamese.dyndns.org>

On Sat, Dec 01, 2007 at 11:46:52AM -0800, Junio C Hamano wrote:

Show 10 quoted lines

> On Sat, Dec 01, 2007 at 07:01:13PM +0300, Dmitry V. Levin wrote:
> 
> > When checking buffer for NUL byte, do not limit size of buffer we check.
> > Otherwise we break git-rebase: git-format-patch may generate output which
> > git-mailinfo cannot handle properly.
> 
> I think this is tackling a valid problem but it is a wrong solution.
> The change penalizes text changes which is the majority, just in case
> there is an unusual change that has an embedded NUL far into the file
> (iow, exception).

Penalizes? Average file size in the linux-2.6.23.9 kernel tree is 10944 bytes, FIRST_FEW_BYTES limit is 8000 bytes. Well, I prefer slightly penalized but working properly git-rebase. Attached test case demonstrates how current git-rebase can just run successfully but produce a wrong result.

P.S. The real life example where you can hit this git-rebase problem is GNU .info files.

-- 
ldv