git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: convert from perl internal to utf8 for commitdiff_plain

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 30, 2008, 05:10 UTC
Message-ID
<7vejbzkifq.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<87ejc0j08t.wl@mail2.atmark-techno.com>
Yasushi SHOJI <yashi@atmark-techno.com> writes:
Show 18 quoted lines
>> > sorry about my stupid english.  What I meant was that because commi=
> t
>> > log doesn't say _why_ it changed to here-doc, I couldn't be sure it
>> > was ok to overwrite the change introduced by the commit 59b9f61a3.
>> >
>> > IOW, I was tring to ask, "is it ok to revert back to print?"
>>=20
>> Sure.  Can I forge your Sign-off?
>
> =46rom 127a6abaf23991394b3b2c5455c2522f9da1e8ac Mon Sep 17 00:00:00 200=
> 1
> =46rom: Yasushi SHOJI <yashi@wat.atmark-techno.com>
> Date: Tue, 29 Jan 2008 20:48:33 +0900
> Subject: [PATCH] gitweb: Convert generated contents to utf8 in commitdi=
> ff_plain
> MIME-Version: 1.0
> Content-Type: text/plain; charset=3Dutf-8
> Content-Transfer-Encoding: 8bit

Please don't do this. MIME headers do not belong to the body of the message.

Show 10 quoted lines
>
> If the commit message, or commit author contains non-ascii, it must be
> converted from Perl internal representation to utf-8, to follow what
> got declared in HTTP header.  Use to_utf8() to do the conversion.
>
> This necessarily replaces here-doc with "print" statements.
>
> Signed-off-by: Yasushi SHOJI <yashi@atmark-techno.com>
> Acked-by: =C4=B0smail D=C3=B6nmez <ismail@pardus.org.tr>
> Acked-by: Jakub Narebski <jnareb@gmail.com>

Will try to apply by hand; if you do not hear from me about this patch again, no need for resend.

Thanks.
Previous: Jakub NarebskiNext: Jakub Narebski
Message 8 of 9 in “gitweb: convert from perl internal to utf8 for commitdiff_plain”
  1. gitweb: convert from perl internal to utf8 for commitdiff_plainYasushi SHOJI, Jan 29, 2008
  2. Ismail DönmezJan 29, 2008
  3. Junio C HamanoJan 29, 2008
  4. Yasushi SHOJIJan 29, 2008
  5. Junio C HamanoJan 29, 2008
  6. Yasushi SHOJIJan 29, 2008
  7. Jakub NarebskiJan 29, 2008
  8. Junio C HamanoJan 30, 2008
  9. Jakub NarebskiJan 29, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.