From: Junio C Hamano Date: Wed, 30 Jan 2008 05:10:01 GMT Subject: Re: [PATCH] gitweb: convert from perl internal to utf8 for commitdiff_plain Message-ID: <7vejbzkifq.fsf@gitster.siamese.dyndns.org> In-Reply-To: <87ejc0j08t.wl@mail2.atmark-techno.com> Yasushi SHOJI writes: >> > sorry about my stupid english. What I meant was that because commi= > t >> > log doesn't say _why_ it changed to here-doc, I couldn't be sure it >> > was ok to overwrite the change introduced by the commit 59b9f61a3. >> > >> > IOW, I was tring to ask, "is it ok to revert back to print?" >>=20 >> Sure. Can I forge your Sign-off? > > =46rom 127a6abaf23991394b3b2c5455c2522f9da1e8ac Mon Sep 17 00:00:00 200= > 1 > =46rom: Yasushi SHOJI > Date: Tue, 29 Jan 2008 20:48:33 +0900 > Subject: [PATCH] gitweb: Convert generated contents to utf8 in commitdi= > ff_plain > MIME-Version: 1.0 > Content-Type: text/plain; charset=3Dutf-8 > Content-Transfer-Encoding: 8bit Please don't do this. MIME headers do not belong to the body of the message. > > If the commit message, or commit author contains non-ascii, it must be > converted from Perl internal representation to utf-8, to follow what > got declared in HTTP header. Use to_utf8() to do the conversion. > > This necessarily replaces here-doc with "print" statements. > > Signed-off-by: Yasushi SHOJI > Acked-by: =C4=B0smail D=C3=B6nmez > Acked-by: Jakub Narebski Will try to apply by hand; if you do not hear from me about this patch again, no need for resend. Thanks.