Re: [PATCH] Add compat/vsnprintf.c for systems that returns -1 on maxsize reached
Wayne Davison <wayne@opencoder.net> writes:
Show 9 quoted lines
> I'd suggest using a longer buf, requesting a longer length (e.g. 3
> instead of 1), and then making sure that the resulting buf is right
> (e.g. "12" instead of "123").
>
> [[char buf[6];
> if (test_vsnprintf(buf, 3, "%s", "12345") != 5
> || strcmp(buf, "12") != 0) return 1;
> if (snprintf(buf, 3, "%s", "12345") != 5
> || strcmp(buf, "12") != 0) return 1]])],
That sounds like a sensible thing to do.
Other than that, the patch in
Message-Id: <200803051646.13343.michal.rokos@nextsoft.cz>
looked Ok to me.
Junio C Hamano <gitster@pobox.com>