From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 05 Mar 2008 21:05:32 GMT
Subject: Re: [PATCH] Add compat/vsnprintf.c for systems that returns -1 on maxsize reached
Message-ID: <7vejaonaoz.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080305155412.GA19295@herod.dreamhost.com>

Wayne Davison <wayne@opencoder.net> writes:

> I'd suggest using a longer buf, requesting a longer length (e.g. 3
> instead of 1), and then making sure that the resulting buf is right
> (e.g. "12" instead of "123").
>
> 		[[char buf[6];
> 		  if (test_vsnprintf(buf, 3, "%s", "12345") != 5
> 		   || strcmp(buf, "12") != 0) return 1;
> 		  if (snprintf(buf, 3, "%s", "12345") != 5
> 		   || strcmp(buf, "12") != 0) return 1]])],

That sounds like a sensible thing to do.

Other than that, the patch in

    Message-Id: <200803051646.13343.michal.rokos@nextsoft.cz>

looked Ok to me.