Re: [PATCH] pretty.c: add %z specifier.

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 21, 2008, 04:48 UTC
Message-ID: <7veja4u1gv.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <5d46db230803201745mb736e98w4925e14b5d92d71d@mail.gmail.com>

"Govind Salinas" <govind@sophiasuchtig.com> writes:

Show 15 quoted lines

> diff --git a/pretty.c b/pretty.c
> index 703f521..fd155ec 100644
> --- a/pretty.c
> +++ b/pretty.c
> @@ -478,6 +478,9 @@ static size_t format_commit_item(struct strbuf
> *sb, const char *placeholder,
>  	case 'n':		/* newline */
>  		strbuf_addch(sb, '\n');
>  		return 1;
> +	case 'z':		/* null */
> +		strbuf_addch(sb, '\0');
> +		return 1;
>  	}
>
>  	/* these depend on the commit */

I do not like this at all. Why aren't we doing %XX (2 hexadecimal digits for an octet)?