Re: [PATCH] pretty.c: add %z specifier.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 21, 2008, 06:19 UTC
- Message-ID
- <7v8x0csios.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <5d46db230803202242j60b0e9f6q798afd6c5f468207@mail.gmail.com>
"Govind Salinas" <govind@sophiasuchtig.com> writes:
Show 25 quoted lines
> On Fri, Mar 21, 2008 at 12:09 AM, Junio C Hamano <gitster@pobox.com> wrote: >> >> Jeff King <peff@peff.net> writes: >> >> > On Thu, Mar 20, 2008 at 09:48:16PM -0700, Junio C Hamano wrote: >> > >> >> > + case 'z': /* null */ >> >> > + strbuf_addch(sb, '\0'); >> >> > + return 1; >> >> > } >> >> > >> >> > /* these depend on the commit */ >> >> >> >> I do not like this at all. Why aren't we doing %XX (2 hexadecimal digits >> >> for an octet)? >> > >> > Because %ad is already taken? :) >> > >> > %x* is still available, though, so maybe %x00? >> >> Perhaps, but before I forget. >> ... > > Sorry, I'm a bit confused. Should I alter the patch to use a different code > for null, that would be fine by me? The above seems to be an unrelated issue.
Sorry for confusing you. The above is an unrelated issue. But at least to me it is much more important one. I would not be unhappy at all if we did not have either %z nor %x00, but the above bugs me moderately. Also I suspect the proper fix for that issue would involve the part in log-tree you touched.
By the way, I think Jeff's suggestion of %x00 makes more sense than %z.
pretty.c | 13 +++++++++++++ 1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/pretty.c b/pretty.c index 16bfb86..308bfad 100644 --- a/pretty.c +++ b/pretty.c @@ -457,6 +457,7 @@ static size_t format_commit_item(struct strbuf *sb, const char *placeholder, const struct commit *commit = c->commit; const char *msg = commit->buffer; struct commit_list *p; + int h1, h2; /* these are independent of the commit */ switch (placeholder[0]) { @@ -478,6 +479,18 @@ static size_t format_commit_item(struct strbuf *sb, const char *placeholder, case 'n': /* newline */ strbuf_addch(sb, '\n'); return 1; + case 'x': + /* %x00 == NUL, %x0a == LF, etc. */ + if (0 <= (h1 = hexval_table[0xff & placeholder[1]]) && + h1 <= 16 && + 0 <= (h2 = hexval_table[0xff & placeholder[2]]) && + h2 <= 16) { + strbuf_addch(sb, (h1<<4)|h2); + return 2; + } else { + return 0; + } + } /* these depend on the commit */