git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add color.diff.{header,message} formats

From
Junio C Hamano <gitster@pobox.com>
Date
May 17, 2008, 18:17 UTC
Message-ID
<7vej80dcdc.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20080517130739.GA2326@artemis.madism.org>
Pierre Habouzit <madcoder@debian.org> writes:
>   Hmmm it seems this patch has been somehow lost somewhere, is there
> anything wrong with it ?

It may not break anything, and I did not hear anybody on the list who said this breaks soemthing. But I did not hear anybody on the list who wanted to have this except you, either. At this stage of development, the question we should be asking is not if there is anything wrong with it, but if there is anything _good_ with it.

It looks rather widespread compared to a perceived benefit. Perhaps after a refactoring to make the parameter to pretty-print-commit a bit more easily extensible, the patch might start looking more promising. I dunno.

Previous: Pierre HabouzitNext: Pierre Habouzit
Message 3 of 4 in “Add color.diff.{header,message} formats”
  1. Add color.diff.{header,message} formatsPierre Habouzit, May 5, 2008
  2. Pierre HabouzitMay 17, 2008
  3. Junio C HamanoMay 17, 2008
  4. Pierre HabouzitMay 17, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.