Re: [PATCH] Add color.diff.{header,message} formats
On Sat, May 17, 2008 at 06:17:03PM +0000, Junio C Hamano wrote:
Show 10 quoted lines
> Pierre Habouzit <madcoder@debian.org> writes:
>
> > Hmmm it seems this patch has been somehow lost somewhere, is there
> > anything wrong with it ?
>
> It may not break anything, and I did not hear anybody on the list who said
> this breaks soemthing. But I did not hear anybody on the list who wanted
> to have this except you, either. At this stage of development, the
> question we should be asking is not if there is anything wrong with it,
> but if there is anything _good_ with it.
Well the thing is that I (and the few people that made me write the
patch) find git log -p hard to read, because my eyes tend to not see the
separations between two commits. Having a different color for commit
messages help a lot.
> It looks rather widespread compared to a perceived benefit. Perhaps after
> a refactoring to make the parameter to pretty-print-commit a bit more
> easily extensible, the patch might start looking more promising. I dunno.
Fair enough, I wrote the patch for others, I use it on my git, but I'm
not really into doing that amount of work to push it in git.git either …
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org
Pierre Habouzit <madcoder@debian.org>