Re: [PATCH] Honor git-reset -q by silencing progress updates.

From: Junio C Hamano <gitster@pobox.com>
Date: May 31, 2008, 22:43 UTC
Message-ID: <7vej7idrgw.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <32206B67-D97A-459E-BA48-D3B343D775F3@37signals.com>

Jamis Buck <jamis@37signals.com> writes:

Show 6 quoted lines

> --Apple-Mail-10--112802933
> Content-Type: text/plain;
> 	charset=US-ASCII;
> 	format=flowed;
> 	delsp=yes
> Content-Transfer-Encoding: 7bit

Please do not do unnecessary S/MIME nor format=flawed. It makes reviewing and application of the patches inconvenient.

Show 21 quoted lines

>
> When running git-reset in a non-interactive setting, the -q switch
> works for everything except the progress updates. This patch attempts
> to extend the application of -q to suppress that, too.
> ---
> builtin-reset.c |    9 +++++----
> 1 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/builtin-reset.c b/builtin-reset.c
> index e32ddd9..3810f6d 100644
> --- a/builtin-reset.c
> +++ b/builtin-reset.c
> @@ -49,13 +49,14 @@ static inline int is_merge(void)
> 	return !access(git_path("MERGE_HEAD"), F_OK);
> }
>
> -static int reset_index_file(const unsigned char *sha1, int  
> is_hard_reset)
> +static int reset_index_file(const unsigned char *sha1, int  
> is_hard_reset, int quiet)
> {