git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Honor git-reset -q by silencing progress updates.

From
JBJamis Buck <jamis@37signals.com>
Date
May 31, 2008, 21:41 UTC
Message-ID
<32206B67-D97A-459E-BA48-D3B343D775F3@37signals.com>

When running git-reset in a non-interactive setting, the -q switch works for everything except the progress updates. This patch attempts to extend the application of -q to suppress that, too. --- builtin-reset.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/builtin-reset.c b/builtin-reset.c
index e32ddd9..3810f6d 100644
--- a/builtin-reset.c
+++ b/builtin-reset.c
@@ -49,13 +49,14 @@ static inline int is_merge(void)
	return !access(git_path("MERGE_HEAD"), F_OK);
}

-static int reset_index_file(const unsigned char *sha1, int  
is_hard_reset)
+static int reset_index_file(const unsigned char *sha1, int  
is_hard_reset, int quiet)
{
	int i = 0;
	const char *args[6];

	args[i++] = "read-tree";
-	args[i++] = "-v";
+	if (!quiet)
+		args[i++] = "-v";
	args[i++] = "--reset";
	if (is_hard_reset)
		args[i++] = "-u";
@@ -182,7 +183,7 @@ int cmd_reset(int argc, const char **argv, const  
char *prefix)
		OPT_SET_INT(0, "hard", &reset_type,
				"reset HEAD, index and working tree", HARD),
		OPT_BOOLEAN('q', NULL, &quiet,
-				"disable showing new HEAD in hard reset"),
+				"disable progress and showing new HEAD in hard reset"),
		OPT_END()
	};

@@ -231,7 +232,7 @@ int cmd_reset(int argc, const char **argv, const  
char *prefix)
		if (is_merge() || read_cache() < 0 || unmerged_cache())
			die("Cannot do a soft reset in the middle of a merge.");
	}
-	else if (reset_index_file(sha1, (reset_type == HARD)))
+	else if (reset_index_file(sha1, (reset_type == HARD), quiet))
		die("Could not reset index file to revision '%s'.", rev);

	/* Any resets update HEAD to the head being switched to,
-- 
1.5.5.1
Next: Junio C Hamano
Message 1 of 2 in “Honor git-reset -q by silencing progress updates.”
  1. Honor git-reset -q by silencing progress updates.Jamis Buck, May 31, 2008
  2. Junio C HamanoMay 31, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.