Re: [PATCH] Fix http-push test

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 7, 2008, 19:54 UTC
Message-ID: <7vej6531xa.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080707190847.GA24489@glandium.org>

Mike Hommey <mh@glandium.org> writes:

Show 13 quoted lines

> On Mon, Jul 07, 2008 at 09:02:37PM +0200, Mike Hommey wrote:
>> http-push test has been broken by 4a7aaccd adding a space character
>> in the place where the test is being run.
>> ---
>> 
>>  Note that the 4th test doesn't pass because of the new git clone, that
>>  creates the clone with packed-refs instead of refs/heads/master that
>>  push is requiring. But this also means push was already broken with
>>  repositories with packed-refs.
>
> Actually, the 3rd is failing too, but fails to report an error because
> git push returns no error code in cases where it says:
>   No refs in common and none specified; doing nothing.

Ok, when you are done checking, care to send in a replacement patch with failing one marked with test_expect_failure?

You do not have to hurry, I am currently at day job and already deep in today's integration cycle during the lunchtime, and won't be able to queue new fixes for several hours from now, so your patch will be part of tomorrow's or tonight's cycle anyway.